Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add more test cases for plan cache #56869

Merged
merged 3 commits into from
Oct 28, 2024
Merged

planner: add more test cases for plan cache #56869

merged 3 commits into from
Oct 28, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Oct 28, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: add more test cases for plan cache

What changed and how does it work?

planner: add more test cases for plan cache

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 28, 2024
@tiprow tiprow
Copy link

tiprow bot commented Oct 28, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-28 06:56:45.904520305 +0000 UTC m=+246518.743675843: ☑️ agreed by AilinKid.
  • 2024-10-28 06:58:04.183827441 +0000 UTC m=+246597.022982986: ☑️ agreed by Rustin170506.

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.3386%. Comparing base (c550aae) to head (96ee203).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #56869         +/-   ##
=================================================
- Coverage   73.3393%   56.3386%   -17.0008%     
=================================================
  Files          1636       1761        +125     
  Lines        453658     632571     +178913     
=================================================
+ Hits         332710     356382      +23672     
- Misses       100561     252117     +151556     
- Partials      20387      24072       +3685
Flag Coverage Δ
integration 37.0610% <ø> (?)
unit 72.5252% <ø> (-0.0265%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6850% <ø> (+6.7084%) ⬆️

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qw4990
Copy link
Contributor Author

qw4990 commented Oct 28, 2024

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Oct 28, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 5ab6738 into pingcap:master Oct 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@AilinKid AilinKid AilinKid approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @hawkingrei @AilinKid @Rustin170506